From c2e40fed8d6d4f4edcabf394e926dfb40f9d968c Mon Sep 17 00:00:00 2001
From: Nelson Jovel <memoryman51@hotmail.com>
Date: Fri, 29 Apr 2022 07:40:47 -0700
Subject: [PATCH] Do not count empty survey items in response rate
 calculations.  Fixes #181922483

---
 app/models/student_response_rate.rb | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/app/models/student_response_rate.rb b/app/models/student_response_rate.rb
index 9964b583..d1172c71 100644
--- a/app/models/student_response_rate.rb
+++ b/app/models/student_response_rate.rb
@@ -9,7 +9,9 @@ class StudentResponseRate
       survey_items = SurveyItem.includes(%i[scale
                                             measure]).student_survey_items.where("scale.measure": @subcategory.measures)
       survey_items = survey_items.where(on_short_form: true) if survey.form == 'short'
-      survey_items = survey_items.reject { |survey_item| survey_item.survey_item_responses.count == 0 }
+      survey_items = survey_items.reject do |survey_item|
+        survey_item.survey_item_responses.where(school: @school, academic_year: @academic_year).count == 0
+      end
       survey_items.count
     end
   end