From c2503541ffa5a2f95a7a60638d5fd4e517d07e71 Mon Sep 17 00:00:00 2001 From: rebuilt Date: Wed, 7 Jun 2023 12:36:56 -0700 Subject: [PATCH] Fix: Ensure proper detection of survey type. Make sure to remove any survey item ids that end with the survey variant style of '-1' --- app/models/survey_item.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/models/survey_item.rb b/app/models/survey_item.rb index 0f985c9e..0d910232 100644 --- a/app/models/survey_item.rb +++ b/app/models/survey_item.rb @@ -66,7 +66,7 @@ class SurveyItem < ActiveRecord::Base end def self.survey_type(survey_item_ids:) - survey_item_ids = survey_item_ids.to_set + survey_item_ids = survey_item_ids.reject { |id| id.ends_with?('-1') }.to_set return :short_form if survey_item_ids.subset? short_form_survey_items.map(&:survey_item_id).to_set return :early_education if survey_item_ids.subset? early_education_survey_items.map(&:survey_item_id).to_set return :teacher if survey_item_ids.subset? teacher_survey_items.map(&:survey_item_id).to_set