Add links to subcategories from overview page framework indicator

section.   Finishes #181681266
pull/1/head
Nelson Jovel 4 years ago
parent 5a9e8a9b01
commit bf8b824ab8

@ -1,8 +1,11 @@
class SubcategoryCardPresenter class SubcategoryCardPresenter
attr_reader :name attr_reader :name, :subcategory, :category, :subcategory_id
def initialize(name:, zones:, score:) def initialize(subcategory:, zones:, score:)
@name = name @name = subcategory.name
@subcategory = subcategory
@category = subcategory.category
@subcategory_id = subcategory.subcategory_id
@zones = zones @zones = zones
@score = score @score = score
end end
@ -19,6 +22,10 @@ class SubcategoryCardPresenter
zone.type == :insufficient_data zone.type == :insufficient_data
end end
def to_model
subcategory
end
private private
def zone def zone

@ -22,7 +22,7 @@ class SubcategoryPresenter
end end
def subcategory_card_presenter def subcategory_card_presenter
SubcategoryCardPresenter.new(name: @subcategory.name, zones:, score: average_score) SubcategoryCardPresenter.new(subcategory: @subcategory, zones:, score: average_score)
end end
def average_score def average_score

@ -1,4 +1,4 @@
<section class="subcategory-section"> <section id="<%= subcategory.id %>" class="subcategory-section">
<div class="p-7"> <div class="p-7">
<p class="construct-id">Subcategory <%= subcategory.id %></p> <p class="construct-id">Subcategory <%= subcategory.id %></p>
<h2 class="sub-header-2 font-bitter mb-7"><%= subcategory.name %></h2> <h2 class="sub-header-2 font-bitter mb-7"><%= subcategory.name %></h2>

@ -3,5 +3,5 @@
<use class="harvey-ball harvey-ball--<%= subcategory_card.color %>" xlink:href="#<%= subcategory_card.harvey_ball_icon %>"></use> <use class="harvey-ball harvey-ball--<%= subcategory_card.color %>" xlink:href="#<%= subcategory_card.harvey_ball_icon %>"></use>
</svg> </svg>
<div class="subcategory-card__name"><%= subcategory_card.name %></div> <%= link_to(subcategory_card.name, district_school_category_path( @district, @school, subcategory_card.category, {year: @academic_year.range, anchor: "#{subcategory_card.subcategory_id}"})) %>
</div> </div>

@ -10,7 +10,7 @@ describe SubcategoryCardPresenter do
) )
end end
let(:subcategory_card_presenter) { SubcategoryCardPresenter.new(name: 'Card name', zones:, score:) } let(:subcategory_card_presenter) { SubcategoryCardPresenter.new(subcategory: Subcategory.new(name: 'A subcategory'), zones:, score:) }
context 'when the given score is in the Warning zone for the given scale' do context 'when the given score is in the Warning zone for the given scale' do
let(:score) { 1 } let(:score) { 1 }

Loading…
Cancel
Save