Finishes #180264854. Prevents empty dataset modal from displaying on browse page

pull/1/head
Nelson Jovel 4 years ago
parent b45dca7a5a
commit bde992c96b

@ -90,3 +90,5 @@
<%= render partial: "variance_chart", locals: { presenters: @variance_chart_row_presenters} %>
</div>
<%= render partial: 'layouts/empty_dataset_modal' if @has_empty_dataset %>

@ -33,7 +33,5 @@
<%= render partial: 'layouts/footer' %>
</div>
<%= render partial: 'layouts/empty_dataset_modal' if @has_empty_dataset %>
</body>
</html>

@ -13,11 +13,14 @@ describe 'SQM Application' do
end
context 'when no measures meet their threshold' do
it 'shows a modal on all pages' do
[dashboard_path, browse_path].each do |path|
visit path
expect(page).to have_css '.modal'
end
it 'shows a modal on dashboard page' do
visit dashboard_path
expect(page).to have_css '.modal'
end
it 'does not show a modal on the browse page' do
visit browse_path
expect(page).not_to have_css '.modal'
end
end

Loading…
Cancel
Save