diff --git a/app/controllers/dashboard_controller.rb b/app/controllers/dashboard_controller.rb
index fa4bd1ee..fac83f40 100644
--- a/app/controllers/dashboard_controller.rb
+++ b/app/controllers/dashboard_controller.rb
@@ -1,24 +1,16 @@
class DashboardController < SqmApplicationController
def index
- @measure_graph_row_presenters = measure_ids
- .map { |measure_id| Measure.find_by_measure_id measure_id }
- .map(&method(:presenter_for_measure))
- .sort
- .reverse
+ @variance_chart_row_presenters = Measure.all.map(&method(:presenter_for_measure))
@category_presenters = SqmCategory.sorted.map { |sqm_category| CategoryPresenter.new(category: sqm_category) }
end
private
- def measure_ids
- Measure.all.map(&:measure_id)
- end
-
def presenter_for_measure(measure)
score = SurveyItemResponse.score_for_measure(measure: measure, school: @school, academic_year: @academic_year)
- MeasureGraphRowPresenter.new(measure: measure, score: score)
+ VarianceChartRowPresenter.new(measure: measure, score: score)
end
end
diff --git a/app/helpers/variance_helper.rb b/app/helpers/variance_helper.rb
index 5ff88e2a..e66fbcb3 100644
--- a/app/helpers/variance_helper.rb
+++ b/app/helpers/variance_helper.rb
@@ -42,12 +42,4 @@ module VarianceHelper
def zone_width_percentage
100.0/zones.size
end
-
- def measures_with_insufficient_data(presenters:)
- presenters.filter { |presenter| presenter.score == nil }
- end
-
- def measures_with_sufficient_data(presenters:)
- presenters.filter { |presenter| presenter.score != nil }
- end
end
diff --git a/app/presenters/measure_graph_row_presenter.rb b/app/presenters/variance_chart_row_presenter.rb
similarity index 96%
rename from app/presenters/measure_graph_row_presenter.rb
rename to app/presenters/variance_chart_row_presenter.rb
index f11ab77d..fff4025b 100644
--- a/app/presenters/measure_graph_row_presenter.rb
+++ b/app/presenters/variance_chart_row_presenter.rb
@@ -1,4 +1,4 @@
-class MeasureGraphRowPresenter
+class VarianceChartRowPresenter
include Comparable
attr_reader :score
@@ -49,7 +49,7 @@ class MeasureGraphRowPresenter
end
def <=>(other_presenter)
- order <=> other_presenter.order
+ other_presenter.order <=> order
end
private
diff --git a/app/views/dashboard/_variance_graph.erb b/app/views/dashboard/_variance_chart.html.erb
similarity index 87%
rename from app/views/dashboard/_variance_graph.erb
rename to app/views/dashboard/_variance_chart.html.erb
index c6305e3b..7f891dc5 100644
--- a/app/views/dashboard/_variance_graph.erb
+++ b/app/views/dashboard/_variance_chart.html.erb
@@ -1,8 +1,10 @@
-<% unless measures_with_insufficient_data(presenters: presenters).empty? %>
-
Note: The following measures are not displayed due to limited availability of school admin data and/or low survey response rates: <%= measures_with_insufficient_data(presenters: presenters).map(&:measure_name).join('; ') %>.
Note: The following measures are not displayed due to limited availability of school admin data and/or low survey response rates: <%= not_displayed_presenters.map(&:measure_name).join('; ') %>.
<% end %>
-<% displayed_presenters = measures_with_sufficient_data(presenters: presenters) %>