From 9e368ae47db9aca5fa16f77593cdfdb33caa7f16 Mon Sep 17 00:00:00 2001 From: Nelson Jovel Date: Thu, 21 Dec 2023 13:54:54 -0800 Subject: [PATCH] chore: prevent multiple lookups for the boston district by inlining the sql --- app/models/survey_item_response.rb | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/models/survey_item_response.rb b/app/models/survey_item_response.rb index 03dd4585..526ea329 100644 --- a/app/models/survey_item_response.rb +++ b/app/models/survey_item_response.rb @@ -16,8 +16,7 @@ class SurveyItemResponse < ActiveRecord::Base has_one :measure, through: :survey_item scope :exclude_boston, lambda { - boston = District.find_by_name("Boston") - where.not(school: boston.schools) if boston.present? + includes(school: :district).where.not("district.name": "Boston") } scope :averages_for_grade, lambda { |survey_items, school, academic_year, grade|