From 9d45ba405bf83a72111d96a59abb23f29f2dbb05 Mon Sep 17 00:00:00 2001
From: Jared Cosulich <jared.cosulich@gmail.com>
Date: Sun, 28 Jan 2018 22:06:35 -0500
Subject: [PATCH] capping zscores at 2

---
 app/models/school_category.rb       | 14 ++++++--------
 app/views/categories/show.html.haml |  2 +-
 lib/tasks/data.rake                 |  2 +-
 3 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/app/models/school_category.rb b/app/models/school_category.rb
index b7ecd763..0dca8370 100644
--- a/app/models/school_category.rb
+++ b/app/models/school_category.rb
@@ -37,13 +37,11 @@ class SchoolCategory < ApplicationRecord
       SchoolCategory.for(school, cc).valid
     end.flatten.compact
 
-    new_zscore = zscore
-    if new_zscore.nil?
-      zscore_categories = child_school_categories.select { |csc| csc.zscore.present? }
-      if zscore_categories.length > 0
-        total_zscore = zscore_categories.inject(0) { |total, zc| total + zc.zscore }
-        new_zscore = total_zscore / zscore_categories.length
-      end
+    average_zscore = nil
+    zscore_categories = child_school_categories.select { |csc| csc.zscore.present? }
+    if zscore_categories.length > 0
+      total_zscore = zscore_categories.inject(0) { |total, zc| total + zc.zscore }
+      average_zscore = total_zscore / zscore_categories.length
     end
 
     return {
@@ -56,7 +54,7 @@ class SchoolCategory < ApplicationRecord
       answer_index_total:
         _aggregated_responses[:answer_index_total] +
         child_school_categories.inject(0) { |total, csc| total + csc.answer_index_total },
-      zscore: new_zscore
+      zscore: average_zscore.present? ? average_zscore : zscore
     }
   end
 
diff --git a/app/views/categories/show.html.haml b/app/views/categories/show.html.haml
index 31394352..5408840e 100644
--- a/app/views/categories/show.html.haml
+++ b/app/views/categories/show.html.haml
@@ -33,7 +33,7 @@
             = "(Benchmark: #{@school_category.category.benchmark})"
             &nbsp;
           - if @school_category.zscore.present?
-            = [(@school_category.zscore.round(1) + 3), 5].min
+            = @school_category.zscore.round(1) + 3
             (out of 5)
 
 
diff --git a/lib/tasks/data.rake b/lib/tasks/data.rake
index f6e91fed..d6b771cd 100644
--- a/lib/tasks/data.rake
+++ b/lib/tasks/data.rake
@@ -282,7 +282,7 @@ namespace :data do
       school_category = school.school_categories.find_or_create_by(category: nonlikert_category)
       school_category.update(
         nonlikert: row["NL_Value"],
-        zscore: row["Z-Score"]
+        zscore: [row["Z-Score"].to_f,2].min
       )
       school_category_id = school_category.id
     end