From 98ba54c30509b0d21c2c47a1b7dd143bc9d8da8c Mon Sep 17 00:00:00 2001
From: Nelson Jovel <memoryman51@hotmail.com>
Date: Tue, 7 Mar 2023 22:38:52 -0800
Subject: [PATCH] Convert dese::loader from using seeder to factories

---
 spec/services/dese/loader_spec.rb | 44 +++++++++++++++++++++----------
 1 file changed, 30 insertions(+), 14 deletions(-)

diff --git a/spec/services/dese/loader_spec.rb b/spec/services/dese/loader_spec.rb
index 4657ed8a..27d2f66a 100644
--- a/spec/services/dese/loader_spec.rb
+++ b/spec/services/dese/loader_spec.rb
@@ -1,23 +1,39 @@
 require 'rails_helper'
 RSpec.describe Dese::Loader do
   let(:path_to_admin_data) { Rails.root.join('spec', 'fixtures', 'sample_four_d_data.csv') }
-  let(:ay_2020_21) { AcademicYear.find_by_range '2020-21' }
-  let(:ay_2018_19) { AcademicYear.find_by_range '2018-19' }
-  let(:ay_2017_18) { AcademicYear.find_by_range '2017-18' }
-  let(:ay_2016_17) { AcademicYear.find_by_range '2016-17' }
-  let(:four_d) { AdminDataItem.find_by_admin_data_item_id 'a-cgpr-i1' }
-  let(:attleboro) { School.find_by_dese_id 160_505 }
-  let(:winchester) { School.find_by_dese_id 3_440_505 }
-  let(:milford) { School.find_by_dese_id 1_850_505 }
-  let(:seacoast) { School.find_by_dese_id 2_480_520 }
-  let(:next_wave) { School.find_by_dese_id 2_740_510 }
+
+  let(:ay_2022_23) { create(:academic_year, range: '2022-23') }
+  let(:ay_2021_22) { create(:academic_year, range: '2021-22') }
+  let(:ay_2020_21) { create(:academic_year, range: '2020-21') }
+  let(:ay_2019_20) { create(:academic_year, range: '2019-20') }
+  let(:ay_2018_19) { create(:academic_year, range: '2018-19') }
+  let(:ay_2017_18) { create(:academic_year, range: '2017-18') }
+  let(:ay_2016_17) { create(:academic_year, range: '2016-17') }
+  let(:four_d) { create(:admin_data_item, admin_data_item_id: 'a-cgpr-i1') }
+  let(:attleboro)  { create(:school, dese_id: 160_505) }
+  let(:winchester) { create(:school, dese_id: 3_440_505) }
+  let(:milford)    { create(:school, dese_id: 1_850_505) }
+  let(:seacoast)   { create(:school, dese_id: 2_480_520) }
+  let(:next_wave)  { create(:school, dese_id: 2_740_510) }
 
   before :each do
-    Rails.application.load_seed
+    ay_2022_23
+    ay_2021_22
+    ay_2020_21
+    ay_2019_20
+    ay_2018_19
+    ay_2017_18
+    ay_2016_17
+    four_d
+    attleboro
+    winchester
+    milford
+    seacoast
+    next_wave
   end
 
   after :each do
-    DatabaseCleaner.clean
+    # DatabaseCleaner.clean
   end
   context 'when running the loader' do
     before :each do
@@ -38,13 +54,13 @@ RSpec.describe Dese::Loader do
     end
 
     it 'loads the correct number of items' do
-      expect(AdminDataValue.count).to eq 230
+      expect(AdminDataValue.count).to eq 25
     end
 
     it 'is idempotent' do
       Dese::Loader.load_data filepath: path_to_admin_data
 
-      expect(AdminDataValue.count).to eq 230
+      expect(AdminDataValue.count).to eq 25
     end
   end
 end