diff --git a/app/presenters/admin_data_presenter.rb b/app/presenters/admin_data_presenter.rb index b9a71b30..43350a7f 100644 --- a/app/presenters/admin_data_presenter.rb +++ b/app/presenters/admin_data_presenter.rb @@ -7,7 +7,7 @@ class AdminDataPresenter < DataItemPresenter end def title - 'School admin data' + "School data" end def id @@ -15,7 +15,7 @@ class AdminDataPresenter < DataItemPresenter end def reason_for_insufficiency - 'limited availability' + "limited availability" end def descriptions_and_availability diff --git a/app/views/categories/_subcategory_section.html.erb b/app/views/categories/_subcategory_section.html.erb index 67465382..887f65e0 100644 --- a/app/views/categories/_subcategory_section.html.erb +++ b/app/views/categories/_subcategory_section.html.erb @@ -11,7 +11,7 @@

<%= subcategory.description %>

-

<%= subcategory.admin_collection_rate.first %> / <%= subcategory.admin_collection_rate.last %>

-

school admin data sources

+

school data sources

-
<%= subcategory.student_response_rate %>

of students responded

-

We’re unable to display results for the selected school and school year due to:

You may continue to explore the structure of the ECP School Quality Measures Framework, but we recommend selecting a different school and/or a different school year for the best experience.

diff --git a/app/views/overview/_subcategory_card.html.erb b/app/views/overview/_subcategory_card.html.erb index 728484ed..10a6fdc7 100644 --- a/app/views/overview/_subcategory_card.html.erb +++ b/app/views/overview/_subcategory_card.html.erb @@ -1,5 +1,5 @@
- data-bs-placement="top" data-bs-content="This subcategory is not displayed due to limited availability of school admin data and/or low survey response rates."> + data-bs-placement="top" data-bs-content="This subcategory is not displayed due to limited availability of school data and/or low survey response rates."> diff --git a/app/views/overview/_variance_chart.html.erb b/app/views/overview/_variance_chart.html.erb index a48aa780..2479c48e 100644 --- a/app/views/overview/_variance_chart.html.erb +++ b/app/views/overview/_variance_chart.html.erb @@ -2,9 +2,9 @@ <% not_displayed_presenters = presenters - displayed_presenters %> <% if displayed_presenters.none? %> -

Note: No measures can be displayed due to limited availability of school admin data and/or low survey response rates.

+

Note: No measures can be displayed due to limited availability of school data and/or low survey response rates.

<% elsif not_displayed_presenters.present? %> -

Note: The following measures are not displayed due to limited availability of school admin data and/or low survey response rates: <%= not_displayed_presenters.map(&:measure_name).join('; ') %>.

+

Note: The following measures are not displayed due to limited availability of school data and/or low survey response rates: <%= not_displayed_presenters.map(&:measure_name).join('; ') %>.

<% end %> xmlns="http://www.w3.org/2000/svg"> diff --git a/spec/presenters/measure_presenter_spec.rb b/spec/presenters/measure_presenter_spec.rb index 69eea1fa..7e8ee22a 100644 --- a/spec/presenters/measure_presenter_spec.rb +++ b/spec/presenters/measure_presenter_spec.rb @@ -1,9 +1,9 @@ -require 'rails_helper' +require "rails_helper" describe MeasurePresenter do - let(:academic_year) { create(:academic_year, range: '1989-90') } - let(:school) { create(:school, name: 'Best School') } - let(:measure) { create(:measure, measure_id: 'measure-id') } + let(:academic_year) { create(:academic_year, range: "1989-90") } + let(:school) { create(:school, name: "Best School") } + let(:measure) { create(:measure, measure_id: "measure-id") } let(:teacher_scale) { create(:teacher_scale, measure:) } let(:student_scale) { create(:student_scale, measure:) } let(:admin_scale) { create(:scale, measure:) } @@ -12,18 +12,18 @@ describe MeasurePresenter do create(:respondent, school:, academic_year:) end - it 'returns the id of the measure' do - expect(measure_presenter.id).to eq 'measure-id' + it "returns the id of the measure" do + expect(measure_presenter.id).to eq "measure-id" end - it 'has an id for use in the data item accordions' do - expect(measure_presenter.data_item_accordion_id).to eq 'data-item-accordion-measure-id' + it "has an id for use in the data item accordions" do + expect(measure_presenter.data_item_accordion_id).to eq "data-item-accordion-measure-id" end - context 'when the measure contains only teacher data' do + context "when the measure contains only teacher data" do before :each do - survey_item1 = create(:teacher_survey_item, scale: teacher_scale, prompt: 'A teacher survey item prompt') - survey_item2 = create(:teacher_survey_item, scale: teacher_scale, prompt: 'Another teacher survey item prompt') + survey_item1 = create(:teacher_survey_item, scale: teacher_scale, prompt: "A teacher survey item prompt") + survey_item2 = create(:teacher_survey_item, scale: teacher_scale, prompt: "Another teacher survey item prompt") create_list(:survey_item_response, SurveyItemResponse::TEACHER_RESPONSE_THRESHOLD, survey_item: survey_item1, academic_year:, school:, likert_score: 1) @@ -31,42 +31,42 @@ describe MeasurePresenter do academic_year:, school:, likert_score: 5) end - it 'creates a gauge presenter that presents the average likert score' do - expect(measure_presenter.gauge_presenter.title).to eq 'Growth' + it "creates a gauge presenter that presents the average likert score" do + expect(measure_presenter.gauge_presenter.title).to eq "Growth" end it 'returns a list of data item presenters that has only one element, and that element has a title of "Teacher survey"' do expect(measure_presenter.data_item_presenters.count).to eq 1 - expect(measure_presenter.data_item_presenters.first.id).to eq 'teacher-survey-items-measure-id' - expect(measure_presenter.data_item_presenters.first.title).to eq 'Teacher survey' - expect(measure_presenter.data_item_presenters.first.data_item_accordion_id).to eq 'data-item-accordion-measure-id' + expect(measure_presenter.data_item_presenters.first.id).to eq "teacher-survey-items-measure-id" + expect(measure_presenter.data_item_presenters.first.title).to eq "Teacher survey" + expect(measure_presenter.data_item_presenters.first.data_item_accordion_id).to eq "data-item-accordion-measure-id" end end - context 'when the measure contains both teacher data and admin data' do + context "when the measure contains both teacher data and admin data" do before :each do - create(:teacher_survey_item, scale: teacher_scale, prompt: 'A teacher survey item prompt') - create(:teacher_survey_item, scale: teacher_scale, prompt: 'Another teacher survey item prompt') - create(:admin_data_item, scale: admin_scale, description: 'An admin data item description') - create(:admin_data_item, scale: admin_scale, description: 'Another admin data item description') + create(:teacher_survey_item, scale: teacher_scale, prompt: "A teacher survey item prompt") + create(:teacher_survey_item, scale: teacher_scale, prompt: "Another teacher survey item prompt") + create(:admin_data_item, scale: admin_scale, description: "An admin data item description") + create(:admin_data_item, scale: admin_scale, description: "Another admin data item description") end - it 'returns a list of data item presenters with two elements' do + it "returns a list of data item presenters with two elements" do expect(measure_presenter.data_item_presenters.count).to eq 2 first_data_item_presenter = measure_presenter.data_item_presenters[0] - expect(first_data_item_presenter.id).to eq 'teacher-survey-items-measure-id' - expect(first_data_item_presenter.title).to eq 'Teacher survey' - expect(first_data_item_presenter.data_item_accordion_id).to eq 'data-item-accordion-measure-id' + expect(first_data_item_presenter.id).to eq "teacher-survey-items-measure-id" + expect(first_data_item_presenter.title).to eq "Teacher survey" + expect(first_data_item_presenter.data_item_accordion_id).to eq "data-item-accordion-measure-id" second_data_item_presenter = measure_presenter.data_item_presenters[1] - expect(second_data_item_presenter.id).to eq 'admin-data-items-measure-id' - expect(second_data_item_presenter.title).to eq 'School admin data' - expect(second_data_item_presenter.data_item_accordion_id).to eq 'data-item-accordion-measure-id' + expect(second_data_item_presenter.id).to eq "admin-data-items-measure-id" + expect(second_data_item_presenter.title).to eq "School data" + expect(second_data_item_presenter.data_item_accordion_id).to eq "data-item-accordion-measure-id" end end - context 'when the measure has partial data for teachers and students' do + context "when the measure has partial data for teachers and students" do before :each do teacher_survey_item = create(:teacher_survey_item, scale: teacher_scale) student_survey_item = create(:student_survey_item, scale: student_scale) @@ -77,38 +77,38 @@ describe MeasurePresenter do survey_item: student_survey_item, academic_year:, school:) end - it 'tracks which parts of the data are sufficient' do + it "tracks which parts of the data are sufficient" do teacher_data_item_presenter = measure_presenter.data_item_presenters.find do |presenter| - presenter.title == 'Teacher survey' + presenter.title == "Teacher survey" end student_data_item_presenter = measure_presenter.data_item_presenters.find do |presenter| - presenter.title == 'Student survey' + presenter.title == "Student survey" end expect(teacher_data_item_presenter.sufficient_data?).to be true expect(student_data_item_presenter.sufficient_data?).to be false end end - context 'when the measure has insufficient admin data and insufficient teacher/student data' do + context "when the measure has insufficient admin data and insufficient teacher/student data" do before :each do create(:admin_data_item, scale: admin_scale) create(:teacher_survey_item, scale: teacher_scale) create(:student_survey_item, scale: student_scale) end - it 'tracks the reason for their insufficiency' do + it "tracks the reason for their insufficiency" do teacher_data_item_presenter = measure_presenter.data_item_presenters.find do |presenter| - presenter.title == 'Teacher survey' + presenter.title == "Teacher survey" end student_data_item_presenter = measure_presenter.data_item_presenters.find do |presenter| - presenter.title == 'Student survey' + presenter.title == "Student survey" end admin_data_item_presenter = measure_presenter.data_item_presenters.find do |presenter| - presenter.title == 'School admin data' + presenter.title == "School data" end - expect(teacher_data_item_presenter.reason_for_insufficiency).to eq 'low response rate' - expect(student_data_item_presenter.reason_for_insufficiency).to eq 'low response rate' - expect(admin_data_item_presenter.reason_for_insufficiency).to eq 'limited availability' + expect(teacher_data_item_presenter.reason_for_insufficiency).to eq "low response rate" + expect(student_data_item_presenter.reason_for_insufficiency).to eq "low response rate" + expect(admin_data_item_presenter.reason_for_insufficiency).to eq "limited availability" end end end diff --git a/spec/views/overview/index.html.erb_spec.rb b/spec/views/overview/index.html.erb_spec.rb index ae37311c..375744d3 100644 --- a/spec/views/overview/index.html.erb_spec.rb +++ b/spec/views/overview/index.html.erb_spec.rb @@ -8,11 +8,11 @@ describe "overview/index" do measure = create(:measure, name: "Support For Teaching Development & Growth", measure_id: "1") scale = create(:scale, measure:) create(:student_survey_item, - scale:, - watch_low_benchmark: 1.5, - growth_low_benchmark: 2.5, - approval_low_benchmark: 3.5, - ideal_low_benchmark: 4.5) + scale:, + watch_low_benchmark: 1.5, + growth_low_benchmark: 2.5, + approval_low_benchmark: 3.5, + ideal_low_benchmark: 4.5) measure end @@ -20,11 +20,11 @@ describe "overview/index" do measure = create(:measure, name: "Effective Leadership", measure_id: "2") scale = create(:scale, measure:) create(:teacher_survey_item, - scale:, - watch_low_benchmark: 1.5, - growth_low_benchmark: 2.5, - approval_low_benchmark: 3.5, - ideal_low_benchmark: 4.5) + scale:, + watch_low_benchmark: 1.5, + growth_low_benchmark: 2.5, + approval_low_benchmark: 3.5, + ideal_low_benchmark: 4.5) measure end @@ -32,11 +32,11 @@ describe "overview/index" do measure = create(:measure, name: "Professional Qualifications", measure_id: "3") scale = create(:scale, measure:) create(:admin_data_item, - scale:, - watch_low_benchmark: 1.5, - growth_low_benchmark: 2.5, - approval_low_benchmark: 3.5, - ideal_low_benchmark: 4.5) + scale:, + watch_low_benchmark: 1.5, + growth_low_benchmark: 2.5, + approval_low_benchmark: 3.5, + ideal_low_benchmark: 4.5) measure end @@ -48,13 +48,13 @@ describe "overview/index" do @district = create(:district) @school = create(:school) @student_response_rate_presenter = ResponseRatePresenter.new(focus: :student, school: @school, - academic_year: @academic_year) + academic_year: @academic_year) @teacher_response_rate_presenter = ResponseRatePresenter.new(focus: :teacher, school: @school, - academic_year: @academic_year) + academic_year: @academic_year) Respondent.create!(school: @school, academic_year: @academic_year, total_students: 40, total_teachers: 40) ResponseRate.create!(subcategory: Subcategory.first, school: @school, academic_year: @academic_year, - student_response_rate: 100, teacher_response_rate: 100, meets_student_threshold: true, meets_teacher_threshold: true) + student_response_rate: 100, teacher_response_rate: 100, meets_student_threshold: true, meets_teacher_threshold: true) render end @@ -69,7 +69,7 @@ describe "overview/index" do end it "displays a note detailing which measures have insufficient responses for the given school & academic year" do - expect(rendered).to match %r{Note: The following measures are not displayed due to limited availability of school admin data and/or low survey response rates: Support For Teaching Development & Growth; Professional Qualifications.} + expect(rendered).to match %r{Note: The following measures are not displayed due to limited availability of school data and/or low survey response rates: Support For Teaching Development & Growth; Professional Qualifications.} end it "displays a variance row and label only those presenters for which the score is not nil" do @@ -88,19 +88,19 @@ describe "overview/index" do measure = create(:measure, name: "Display Me", measure_id: "display-me") scale = create(:scale, measure:) create(:student_survey_item, - scale:, - watch_low_benchmark: 1.5, - growth_low_benchmark: 2.5, - approval_low_benchmark: 3.5, - ideal_low_benchmark: 4.5) + scale:, + watch_low_benchmark: 1.5, + growth_low_benchmark: 2.5, + approval_low_benchmark: 3.5, + ideal_low_benchmark: 4.5) [ VarianceChartRowPresenter.new(measure:, - score: Score.new(average: rand)) + score: Score.new(average: rand)) ] end it "does not display a note detailing which measures have insufficient responses for the given school & academic year" do - expect(rendered).not_to match %r{Note: The following measures are not displayed due to limited availability of school admin data and/or low survey response rates} + expect(rendered).not_to match %r{Note: The following measures are not displayed due to limited availability of school data and/or low survey response rates} end it "displays a variance row for each presenter" do diff --git a/spec/views/overview/variance_chart.html.erb_spec.rb b/spec/views/overview/variance_chart.html.erb_spec.rb index 0b1a7436..81c86b72 100644 --- a/spec/views/overview/variance_chart.html.erb_spec.rb +++ b/spec/views/overview/variance_chart.html.erb_spec.rb @@ -1,14 +1,14 @@ -require 'rails_helper' +require "rails_helper" include VarianceHelper -describe 'overview/_variance_chart.html.erb' do +describe "overview/_variance_chart.html.erb" do before do @academic_year = create(:academic_year) @district = create(:district) @school = create(:school) end - context 'When there are scores to show' do + context "When there are scores to show" do subject { Nokogiri::HTML(rendered) } let(:survey_items1) { [create(:student_survey_item)] } @@ -31,24 +31,24 @@ describe 'overview/_variance_chart.html.erb' do VarianceChartRowPresenter.new(measure: higher_scoring_measure, score: Score.new(average: 5)) ] - render partial: 'variance_chart', locals: { presenters: } + render partial: "variance_chart", locals: { presenters: } end - it 'displays higher scoring measures above lower scoring measures' do - measure_row_bars = subject.css('rect.measure-row-bar') + it "displays higher scoring measures above lower scoring measures" do + measure_row_bars = subject.css("rect.measure-row-bar") higher_scoring_measure_index = measure_row_bars.find_index do |bar| - bar['data-for-measure-id'] == higher_scoring_measure.measure_id + bar["data-for-measure-id"] == higher_scoring_measure.measure_id end lower_scoring_measure_index = measure_row_bars.find_index do |bar| - bar['data-for-measure-id'] == lower_scoring_measure.measure_id + bar["data-for-measure-id"] == lower_scoring_measure.measure_id end expect(higher_scoring_measure_index).to be < lower_scoring_measure_index end end - context 'When there are no scores to show for any measures' do + context "When there are no scores to show for any measures" do before :each do measure_lacking_score = create(:measure) another_measure_lacking_score = create(:measure) @@ -57,15 +57,15 @@ describe 'overview/_variance_chart.html.erb' do VarianceChartRowPresenter.new(measure: another_measure_lacking_score, score: Score.new(average: nil)) ] - render partial: 'variance_chart', locals: { presenters: } + render partial: "variance_chart", locals: { presenters: } end it "displays the text 'insufficient data' for an empty dataset" do - expect(rendered).to have_text 'Insufficient data' + expect(rendered).to have_text "Insufficient data" end - it "does not display the partial data text: 'The following measures are not displayed due to limited availability of school admin data and/or low survey response rates:' " do - expect(rendered).not_to have_text 'The following measures are not displayed due to limited availability of school admin data and/or low survey response rates:' + it "does not display the partial data text: 'The following measures are not displayed due to limited availability of school data and/or low survey response rates:' " do + expect(rendered).not_to have_text "The following measures are not displayed due to limited availability of school data and/or low survey response rates:" end end end