fixing merging

app/models/school.rb

@@ -24,14 +24,21 @@ class School < ApplicationRecord
     recipient_lists.update_all(school_id: school.id)
     recipients.update_all(school_id: school.id)
     school_categories.each do |school_category|
-      if school.school_categories.for(school_category.school, school_category.category).in(school_category.year).blank?
-        school_category.update(school_id: school.id)
-      else
-        school_category.destroy
+      school_category.update(school_id: school.id)
+      existing_school_category = school.school_categories.for(school_category.school, school_category.category).in(school_category.year)
+      if existing_school_category.present?
+        if existing_school_category.attempt_count == 0
+          existing_school_category.destroy
+        else
+          school_category.destroy
+        end
       end
     end
+
+    reload
+
     user_schools.update_all(school_id: school.id)
-    school.school_categories.map(&:sync_aggregated_responses)
+    # school.school_categories.map(&:sync_aggregated_responses)
     destroy
   end
 

lib/tasks/data.rake

@@ -9,6 +9,7 @@
 # sudo heroku pg:backups:restore 'https://s3.amazonaws.com/irrationaldesign/latest.dump' DATABASE_URL -a mciea-beta
 # sudo heroku run rake db:migrate -a mciea-beta
 # sudo heroku run console -a mciea-beta -> SchoolCategory.update_all(year: '2017') --  RENAME SCHOOLS = s = SCHOOLS; s.each { |correct, incorrect| District.find_by_name("Boston").schools.find_by_name(incorrect[0]).update(name: incorrect) }
+#        s.map { |correct, incorrect| District.find_by_name("Boston").schools.find_by_name(incorrect.to_s).merge_into(correct)
 # sudo heroku run rake data:load_questions_csv -a mciea-beta
 # sudo heroku run:detached rake data:load_responses -a mciea-beta --size performance-l
 # sudo heroku run rake data:move_likert_to_submeasures -a mciea-beta