Remove unused method item_descriptions from admin_data_presenter and

student_survey_presenter.
pull/1/head
rebuilt 3 years ago
parent a72fd373dc
commit 7a5e02eed9

@ -14,10 +14,6 @@ class AdminDataPresenter < DataItemPresenter
"admin-data-items-#{@measure_id}" "admin-data-items-#{@measure_id}"
end end
def item_descriptions
@admin_data_items.map(&:description)
end
def reason_for_insufficiency def reason_for_insufficiency
'limited availability' 'limited availability'
end end

@ -16,10 +16,6 @@ class StudentSurveyPresenter < DataItemPresenter
"student-survey-items-#{@measure_id}" "student-survey-items-#{@measure_id}"
end end
def item_descriptions
@survey_items.map(&:prompt)
end
def reason_for_insufficiency def reason_for_insufficiency
'low response rate' 'low response rate'
end end

@ -40,39 +40,6 @@ describe AdminDataPresenter do
admin_data_item_5 admin_data_item_5
end end
describe '#item_description' do
context 'When the presenter is based on measure 1A-1' do
it 'returns a list of survey prompts for teacher survey items' do
expect(AdminDataPresenter.new(measure_id: measure_1A_i.measure_id, admin_data_items: measure_1A_i.admin_data_items,
has_sufficient_data: true, school:, academic_year:).item_descriptions).to eq [
'Percentage teachers with 5+ years of experience', 'Percentage teachers National Board certified', 'Percentage teachers teaching in area of licensure'
]
end
context 'When the measure is missing all admin data values' do
it 'if it lacks sufficient data, it shows a warning ' do
expect(AdminDataPresenter.new(measure_id: measure_1A_i.measure_id, admin_data_items: measure_1A_i.admin_data_items,
has_sufficient_data: false, school:, academic_year:).sufficient_data?).to eq false
end
end
context 'When the measure has at least one admin data value' do
it 'if it lacks sufficient data, it doesnt show a warning ' do
expect(AdminDataPresenter.new(measure_id: measure_1A_i.measure_id, admin_data_items: measure_1A_i.admin_data_items,
has_sufficient_data: true, school:, academic_year:).sufficient_data?).to eq true
end
end
end
context 'When the presenter is based on measure 1A-iii' do
it 'returns a message hiding the actual prompts. Instead it presents a message telling the user they can ask for more information' do
expect(AdminDataPresenter.new(measure_id: measure_1A_iii.measure_id, admin_data_items: measure_1A_iii.admin_data_items,
has_sufficient_data: true, school:, academic_year:).item_descriptions).to eq [
'Percent teacher returning (excluding retirement)', 'Percent teachers with 10+ days absent'
]
end
end
end
describe '#descriptions_and_availibility' do describe '#descriptions_and_availibility' do
context 'when there are any matching values for admin data items' do context 'when there are any matching values for admin data items' do
before do before do

Loading…
Cancel
Save