diff --git a/app/presenters/admin_data_presenter.rb b/app/presenters/admin_data_presenter.rb index ec896e6c..294d9f0c 100644 --- a/app/presenters/admin_data_presenter.rb +++ b/app/presenters/admin_data_presenter.rb @@ -14,10 +14,6 @@ class AdminDataPresenter < DataItemPresenter "admin-data-items-#{@measure_id}" end - def item_descriptions - @admin_data_items.map(&:description) - end - def reason_for_insufficiency 'limited availability' end diff --git a/app/presenters/student_survey_presenter.rb b/app/presenters/student_survey_presenter.rb index 4118b8f0..d2fdbafd 100644 --- a/app/presenters/student_survey_presenter.rb +++ b/app/presenters/student_survey_presenter.rb @@ -16,10 +16,6 @@ class StudentSurveyPresenter < DataItemPresenter "student-survey-items-#{@measure_id}" end - def item_descriptions - @survey_items.map(&:prompt) - end - def reason_for_insufficiency 'low response rate' end diff --git a/spec/presenters/data_item_presenters/admin_data_presenter_spec.rb b/spec/presenters/data_item_presenters/admin_data_presenter_spec.rb index aa068914..ca1d479a 100644 --- a/spec/presenters/data_item_presenters/admin_data_presenter_spec.rb +++ b/spec/presenters/data_item_presenters/admin_data_presenter_spec.rb @@ -40,39 +40,6 @@ describe AdminDataPresenter do admin_data_item_5 end - describe '#item_description' do - context 'When the presenter is based on measure 1A-1' do - it 'returns a list of survey prompts for teacher survey items' do - expect(AdminDataPresenter.new(measure_id: measure_1A_i.measure_id, admin_data_items: measure_1A_i.admin_data_items, - has_sufficient_data: true, school:, academic_year:).item_descriptions).to eq [ - 'Percentage teachers with 5+ years of experience', 'Percentage teachers National Board certified', 'Percentage teachers teaching in area of licensure' - ] - end - context 'When the measure is missing all admin data values' do - it 'if it lacks sufficient data, it shows a warning ' do - expect(AdminDataPresenter.new(measure_id: measure_1A_i.measure_id, admin_data_items: measure_1A_i.admin_data_items, - has_sufficient_data: false, school:, academic_year:).sufficient_data?).to eq false - end - end - - context 'When the measure has at least one admin data value' do - it 'if it lacks sufficient data, it doesnt show a warning ' do - expect(AdminDataPresenter.new(measure_id: measure_1A_i.measure_id, admin_data_items: measure_1A_i.admin_data_items, - has_sufficient_data: true, school:, academic_year:).sufficient_data?).to eq true - end - end - end - - context 'When the presenter is based on measure 1A-iii' do - it 'returns a message hiding the actual prompts. Instead it presents a message telling the user they can ask for more information' do - expect(AdminDataPresenter.new(measure_id: measure_1A_iii.measure_id, admin_data_items: measure_1A_iii.admin_data_items, - has_sufficient_data: true, school:, academic_year:).item_descriptions).to eq [ - 'Percent teacher returning (excluding retirement)', 'Percent teachers with 10+ days absent' - ] - end - end - end - describe '#descriptions_and_availibility' do context 'when there are any matching values for admin data items' do before do