Make measure titles clickable on the variance chart

pull/1/head
Nelson Jovel 4 years ago
parent bf8b824ab8
commit 78fb737f5a

@ -1,27 +1,22 @@
class VarianceChartRowPresenter
include Comparable
attr_reader :score
attr_reader :score, :measure_name, :measure_id, :category
def initialize(measure:, score:)
@measure = measure
@score = score.average
@meets_teacher_threshold = score.meets_teacher_threshold?
@meets_student_threshold = score.meets_student_threshold?
@measure_name = @measure.name
@measure_id = @measure.measure_id
@category = @measure.subcategory.category
end
def sufficient_data?
@score != nil
end
def measure_name
@measure.name
end
def measure_id
@measure.measure_id
end
def bar_color
"fill-#{zone.type}"
end

@ -1,4 +1,4 @@
<div class="measure-section mx-4">
<div id="<%= measure_presenter.id %>" class="measure-section mx-4">
<p class="construct-id">Measure <%= measure_presenter.id %></p>
<h3 class="measure-description sub-header-4 mb-5 "><%= measure_presenter.name %></h3>
<div>

@ -89,9 +89,8 @@
data-variance-row-label
width="550"
height="200">
<p class="measure-row-label" xmlns="http://www.w3.org/1999/xhtml">
<%= presenter.measure_name %>
</p>
<%= link_to(presenter.measure_name, district_school_category_path( @district, @school, presenter.category, {year: @academic_year.range, anchor: "#{presenter.measure_id}"}), class: "measure-row-label") %>
</foreignObject>
<% end %>

@ -42,7 +42,10 @@ describe 'overview/index' do
before :each do
assign :category_presenters, []
assign :variance_chart_row_presenters, variance_chart_row_presenters
assign :academic_years, []
@academic_year = create(:academic_year)
assign :academic_years, [@academic_year]
@district = create(:district)
@school = create(:school)
render
end

@ -1,6 +1,12 @@
require 'rails_helper'
describe 'overview/_variance_chart.html.erb' do
before do
@academic_year = create(:academic_year)
@district = create(:district)
@school = create(:school)
end
context 'When there are scores to show' do
subject { Nokogiri::HTML(rendered) }

Loading…
Cancel
Save