diff --git a/app/assets/stylesheets/dashboard.scss b/app/assets/stylesheets/dashboard.scss index 601f2f18..8d7d3603 100644 --- a/app/assets/stylesheets/dashboard.scss +++ b/app/assets/stylesheets/dashboard.scss @@ -92,7 +92,7 @@ fill: $white; } -.harvey-ball--no_zone { +.harvey-ball--insufficient_data { stroke: $gray-2; fill: $gray-3; } diff --git a/app/assets/stylesheets/sqm_application.scss b/app/assets/stylesheets/sqm_application.scss index 626cf922..a622bd6e 100644 --- a/app/assets/stylesheets/sqm_application.scss +++ b/app/assets/stylesheets/sqm_application.scss @@ -39,8 +39,11 @@ } .gauge-title { - margin-top: -1.5em; - margin-bottom: 0; + line-height: 1.2; + max-width: 10ch; + text-align: center; + bottom: 0; + position: absolute; } .measure-section { diff --git a/app/presenters/gauge_presenter.rb b/app/presenters/gauge_presenter.rb index b41193c0..955271f8 100644 --- a/app/presenters/gauge_presenter.rb +++ b/app/presenters/gauge_presenter.rb @@ -5,7 +5,7 @@ class GaugePresenter end def title - zone.type.to_s.capitalize + zone.type.to_s.titleize end def color_class diff --git a/app/presenters/scale.rb b/app/presenters/scale.rb index 5707d582..5f4d189a 100644 --- a/app/presenters/scale.rb +++ b/app/presenters/scale.rb @@ -29,8 +29,8 @@ class Scale Zone.new(@ideal_low_benchmark, 5.0, :ideal) end - def no_zone - Zone.new(0,@warning_low_benchmark,:no_zone) + def insufficient_data + Zone.new(0,@warning_low_benchmark,:insufficient_data) end def zone_for_score(score) @@ -46,7 +46,7 @@ class Scale when 1..warning_zone.high_benchmark warning_zone else - no_zone + insufficient_data end end end diff --git a/app/presenters/subcategory_card_presenter.rb b/app/presenters/subcategory_card_presenter.rb index a3a7924e..b97f39bb 100644 --- a/app/presenters/subcategory_card_presenter.rb +++ b/app/presenters/subcategory_card_presenter.rb @@ -14,7 +14,7 @@ class SubcategoryCardPresenter growth: "half-circle", watch: "one-quarter-circle", warning: "full-circle", - no_zone: "full-circle" + insufficient_data: "full-circle" } icons_by_zone_type[zone.type] end @@ -24,7 +24,7 @@ class SubcategoryCardPresenter end def insufficient_data? - zone.type == :no_zone + zone.type == :insufficient_data end private diff --git a/app/presenters/variance_chart_row_presenter.rb b/app/presenters/variance_chart_row_presenter.rb index fff4025b..c788872e 100644 --- a/app/presenters/variance_chart_row_presenter.rb +++ b/app/presenters/variance_chart_row_presenter.rb @@ -43,7 +43,7 @@ class VarianceChartRowPresenter bar_width_percentage when :warning, :watch, :growth -bar_width_percentage - when :no_zone + when :insufficient_data -100 end end diff --git a/app/views/sqm_categories/_gauge_graph.html.erb b/app/views/sqm_categories/_gauge_graph.html.erb index 07d6ff79..26d9ca69 100644 --- a/app/views/sqm_categories/_gauge_graph.html.erb +++ b/app/views/sqm_categories/_gauge_graph.html.erb @@ -1,4 +1,4 @@ -
<%= gauge.title %>
+<%= gauge.title %>