From 6477792f1d22b48520f0682f91462b759cc137d3 Mon Sep 17 00:00:00 2001
From: Liam Morley <lmorley@vmware.com>
Date: Wed, 1 Dec 2021 14:24:53 -0500
Subject: [PATCH] Improve efficiency when checking whether survey item
 responses already exist

- see https://semaphoreci.com/blog/2017/03/14/faster-rails-how-to-check-if-a-record-exists.html for more info if curious
---
 app/services/survey_responses_data_loader.rb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/services/survey_responses_data_loader.rb b/app/services/survey_responses_data_loader.rb
index f27db71d..d03efc2f 100644
--- a/app/services/survey_responses_data_loader.rb
+++ b/app/services/survey_responses_data_loader.rb
@@ -38,7 +38,7 @@ class SurveyResponsesDataLoader
     return if school.nil?
 
     survey_items.map do |survey_item|
-      next unless SurveyItemResponse.find_by(response_id: response_id, survey_item: survey_item).nil?
+      next if SurveyItemResponse.where(response_id: response_id, survey_item: survey_item).exists?
 
       likert_score = row[survey_item.survey_item_id]
       next if likert_score.nil?