From 4f0b92fa79c2f740d46622c0f88540116761a9a0 Mon Sep 17 00:00:00 2001 From: rebuilt Date: Fri, 15 Jul 2022 16:54:59 -0700 Subject: [PATCH] set up formatters --- .erb-lint.yml | 9 ------ .rubocop.yml | 2 ++ .solargraph.yml | 4 +++ Gemfile | 10 +++++-- Gemfile.lock | 74 +++++++++++++++++++++++++++++++++++++++++++++---- 5 files changed, 82 insertions(+), 17 deletions(-) create mode 100644 .solargraph.yml diff --git a/.erb-lint.yml b/.erb-lint.yml index 76b6772c..86df30c6 100644 --- a/.erb-lint.yml +++ b/.erb-lint.yml @@ -1,11 +1,2 @@ --- EnableDefaultLinters: true -linters: - ErbSafety: - enabled: true - better_html_config: .better-html.yml - Rubocop: - enabled: true - rubocop_config: - inherit_from: - - .rubocop.yml diff --git a/.rubocop.yml b/.rubocop.yml index 55c0c46a..73e129f9 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -1,5 +1,7 @@ inherit_from: ~/.rubocop.yml +AllCops: + TargetRubyVersion: 3.1 Lint/ShadowingOuterLocalVariable: Enabled: false diff --git a/.solargraph.yml b/.solargraph.yml new file mode 100644 index 00000000..b1be5fb7 --- /dev/null +++ b/.solargraph.yml @@ -0,0 +1,4 @@ +plugins: + - solargraph-reek +reporters: + - reek diff --git a/Gemfile b/Gemfile index d896eedb..5a4cc52d 100644 --- a/Gemfile +++ b/Gemfile @@ -59,19 +59,23 @@ group :development, :test do gem 'parallel_tests' gem 'rack-mini-profiler' gem 'rspec-rails', '~> 5.1.0' + gem 'standard' end group :development do # Access an IRB console on exception pages or by using <%= console %> anywhere in the code. + gem 'brakeman' gem 'bullet' + gem 'erb_lint', require: false + gem 'erblint-github' gem 'listen', '~> 3.0.5' gem 'nested_scaffold' + gem 'reek', require: false gem 'rubocop', require: false gem 'seed_dump' - gem 'web-console' - # Spring speeds up development by keeping your application running in the background. Read more: https://github.com/rails/spring - gem 'brakeman' + gem 'solargraph-reek' gem 'spring' + gem 'web-console' end group 'test' do diff --git a/Gemfile.lock b/Gemfile.lock index f3df24d6..43d38f61 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -80,7 +80,17 @@ GEM addressable (2.8.0) public_suffix (>= 2.0.2, < 5.0) ast (2.4.2) + backport (1.2.0) bcrypt (3.1.18) + benchmark (0.2.0) + better_html (1.0.16) + actionview (>= 4.0) + activesupport (>= 4.0) + ast (~> 2.0) + erubi (~> 1.4) + html_tokenizer (~> 0.0.6) + parser (>= 2.4) + smart_properties bindex (0.8.1) bootsnap (1.12.0) msgpack (~> 1.2) @@ -118,6 +128,16 @@ GEM diff-lcs (1.5.0) digest (3.1.0) docile (1.4.0) + e2mmap (0.1.0) + erb_lint (0.1.3) + activesupport + better_html (~> 1.0.7) + html_tokenizer + parser (>= 2.7.1.4) + rainbow + rubocop + smart_properties + erblint-github (0.0.9) erubi (1.10.0) execjs (2.8.1) factory_bot (6.2.1) @@ -134,8 +154,10 @@ GEM temple (>= 0.8.0) tilt hashie (5.0.0) + html_tokenizer (0.0.7) i18n (1.12.0) concurrent-ruby (~> 1.0) + jaro_winkler (1.5.4) jbuilder (2.11.5) actionview (>= 5.0.0) activesupport (>= 5.0.0) @@ -145,8 +167,12 @@ GEM thor (>= 0.14, < 2.0) jsbundling-rails (1.0.2) railties (>= 6.0.0) - json (2.6.2) jwt (1.5.6) + kramdown (2.4.0) + rexml + kramdown-parser-gfm (1.1.0) + kramdown (~> 2.0) + kwalify (0.7.2) launchy (2.5.0) addressable (~> 2.7) listen (3.0.8) @@ -243,10 +269,16 @@ GEM rb-inotify (0.10.1) ffi (~> 1.0) redis (3.3.5) + reek (6.1.1) + kwalify (~> 0.7.0) + parser (~> 3.1.0) + rainbow (>= 2.0, < 4.0) regexp_parser (2.5.0) responders (3.0.1) actionpack (>= 5.0) railties (>= 5.0) + reverse_markdown (2.1.1) + nokogiri rexml (3.2.5) rspec-core (3.11.0) rspec-support (~> 3.11.0) @@ -265,18 +297,20 @@ GEM rspec-mocks (~> 3.10) rspec-support (~> 3.10) rspec-support (3.11.0) - rubocop (1.31.2) - json (~> 2.3) + rubocop (1.29.1) parallel (~> 1.10) parser (>= 3.1.0.0) rainbow (>= 2.2.2, < 4.0) regexp_parser (>= 1.8, < 3.0) rexml (>= 3.2.5, < 4.0) - rubocop-ast (>= 1.18.0, < 2.0) + rubocop-ast (>= 1.17.0, < 2.0) ruby-progressbar (~> 1.7) unicode-display_width (>= 1.4.0, < 3.0) - rubocop-ast (1.18.0) + rubocop-ast (1.19.1) parser (>= 3.1.1.0) + rubocop-performance (1.13.3) + rubocop (>= 1.7.0, < 2.0) + rubocop-ast (>= 0.4.0) ruby-progressbar (1.11.0) seed_dump (3.3.1) activerecord (>= 4) @@ -287,6 +321,25 @@ GEM simplecov_json_formatter (~> 0.1) simplecov-html (0.12.3) simplecov_json_formatter (0.1.4) + smart_properties (1.17.0) + solargraph (0.45.0) + backport (~> 1.2) + benchmark + bundler (>= 1.17.2) + diff-lcs (~> 1.4) + e2mmap + jaro_winkler (~> 1.5) + kramdown (~> 2.3) + kramdown-parser-gfm (~> 1.1) + parser (~> 3.0) + reverse_markdown (>= 1.0.5, < 3) + rubocop (>= 0.52) + thor (~> 1.0) + tilt (~> 2.0) + yard (~> 0.9, >= 0.9.24) + solargraph-reek (0.1.0) + reek (>= 5.0) + solargraph (~> 0.38) spring (4.0.0) sprockets (4.0.3) concurrent-ruby (~> 1.0) @@ -295,6 +348,9 @@ GEM actionpack (>= 5.2) activesupport (>= 5.2) sprockets (>= 3.0.0) + standard (1.12.1) + rubocop (= 1.29.1) + rubocop-performance (= 1.13.3) stimulus-rails (1.0.4) railties (>= 6.0.0) strscan (3.0.3) @@ -324,11 +380,14 @@ GEM activemodel (>= 6.0.0) bindex (>= 0.4.0) railties (>= 6.0.0) + webrick (1.7.0) websocket-driver (0.7.5) websocket-extensions (>= 0.1.0) websocket-extensions (0.1.5) xpath (3.2.0) nokogiri (~> 1.8) + yard (0.9.28) + webrick (~> 1.7.0) zeitwerk (2.6.0) PLATFORMS @@ -346,6 +405,8 @@ DEPENDENCIES cssbundling-rails database_cleaner devise + erb_lint + erblint-github factory_bot_rails friendly_id (~> 5.1.0) haml @@ -365,12 +426,15 @@ DEPENDENCIES rails (~> 7.0.3) rails-controller-testing redis (~> 3.0) + reek rspec-rails (~> 5.1.0) rubocop seed_dump simplecov + solargraph-reek spring sprockets-rails + standard stimulus-rails timecop turbo-rails