From 49a838c0609dd3ff521555ab2733aada50503f82 Mon Sep 17 00:00:00 2001
From: Nelson Jovel <memoryman51@hotmail.com>
Date: Tue, 26 Mar 2024 14:42:14 -0700
Subject: [PATCH] fix: Fixes #187294757.  Data is hidden when selecting
 multiple years if the default year has no student data to show

---
 app/presenters/analyze/graph/column/ell_column/ell_count.rb | 2 +-
 .../analyze/graph/column/gender_column/gender_count.rb      | 2 +-
 .../analyze/graph/column/grouped_bar_column_presenter.rb    | 6 +++---
 .../analyze/graph/column/income_column/income_count.rb      | 2 +-
 .../analyze/graph/column/sped_column/sped_count.rb          | 2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/app/presenters/analyze/graph/column/ell_column/ell_count.rb b/app/presenters/analyze/graph/column/ell_column/ell_count.rb
index fa20518a..66c0ca79 100644
--- a/app/presenters/analyze/graph/column/ell_column/ell_count.rb
+++ b/app/presenters/analyze/graph/column/ell_column/ell_count.rb
@@ -8,7 +8,7 @@ module Analyze
           end
 
           def n_size(year_index)
-            SurveyItemResponse.where(ell:, survey_item: measure.student_survey_items, school:, grade: grades(year_index),
+            SurveyItemResponse.where(ell:, survey_item: measure.student_survey_items, school:, grade: grades,
                                      academic_year: academic_years[year_index]).select(:response_id).distinct.count
           end
         end
diff --git a/app/presenters/analyze/graph/column/gender_column/gender_count.rb b/app/presenters/analyze/graph/column/gender_column/gender_count.rb
index 97460248..874c7cde 100644
--- a/app/presenters/analyze/graph/column/gender_column/gender_count.rb
+++ b/app/presenters/analyze/graph/column/gender_column/gender_count.rb
@@ -8,7 +8,7 @@ module Analyze
           end
 
           def n_size(year_index)
-            SurveyItemResponse.where(gender:, survey_item: measure.student_survey_items, school:, grade: grades(year_index),
+            SurveyItemResponse.where(gender:, survey_item: measure.student_survey_items, school:, grade: grades,
                                      academic_year: academic_years[year_index]).select(:response_id).distinct.count
           end
         end
diff --git a/app/presenters/analyze/graph/column/grouped_bar_column_presenter.rb b/app/presenters/analyze/graph/column/grouped_bar_column_presenter.rb
index 10d924ae..6b28c74a 100644
--- a/app/presenters/analyze/graph/column/grouped_bar_column_presenter.rb
+++ b/app/presenters/analyze/graph/column/grouped_bar_column_presenter.rb
@@ -122,7 +122,7 @@ module Analyze
         end
 
         def n_size(year_index)
-          SurveyItemResponse.where(survey_item: measure.student_survey_items, school:, grade: grades(year_index),
+          SurveyItemResponse.where(survey_item: measure.student_survey_items, school:, grade: grades,
                                    academic_year: academic_years[year_index]).select(:response_id).distinct.count
         end
 
@@ -145,8 +145,8 @@ module Analyze
           end
         end
 
-        def grades(year_index)
-          Respondent.by_school_and_year(school:, academic_year: academic_years[year_index]).enrollment_by_grade.keys
+        def grades
+          Respondent.by_school_and_year(school:, academic_year: academic_years)&.enrollment_by_grade&.keys
         end
 
         private
diff --git a/app/presenters/analyze/graph/column/income_column/income_count.rb b/app/presenters/analyze/graph/column/income_column/income_count.rb
index 642f7308..a61bdc61 100644
--- a/app/presenters/analyze/graph/column/income_column/income_count.rb
+++ b/app/presenters/analyze/graph/column/income_column/income_count.rb
@@ -8,7 +8,7 @@ module Analyze
           end
 
           def n_size(year_index)
-            SurveyItemResponse.where(income:, survey_item: measure.student_survey_items, school:, grade: grades(year_index),
+            SurveyItemResponse.where(income:, survey_item: measure.student_survey_items, school:, grade: grades,
                                      academic_year: academic_years[year_index]).select(:response_id).distinct.count
           end
         end
diff --git a/app/presenters/analyze/graph/column/sped_column/sped_count.rb b/app/presenters/analyze/graph/column/sped_column/sped_count.rb
index 72f1b78f..61975708 100644
--- a/app/presenters/analyze/graph/column/sped_column/sped_count.rb
+++ b/app/presenters/analyze/graph/column/sped_column/sped_count.rb
@@ -8,7 +8,7 @@ module Analyze
           end
 
           def n_size(year_index)
-            SurveyItemResponse.where(sped:, survey_item: measure.student_survey_items, school:, grade: grades(year_index),
+            SurveyItemResponse.where(sped:, survey_item: measure.student_survey_items, school:, grade: grades,
                                      academic_year: academic_years[year_index]).select(:response_id).distinct.count
           end
         end