Extract Google Analytics ID out to an environment variable

TODO- in the future, consider putting this in a credential. We're not able to change the production credentials file currently, but we should change it in the future when we're able
4 years ago · 48f2d64c71
parent 1186579d1b
commit 48f2d64c71
4 changed files with 27 additions and 2 deletions
--- a/app/controllers/home_controller.rb
+++ b/app/controllers/home_controller.rb
@ -1,8 +1,16 @@
 class HomeController < ActionController::Base
+  before_action :set_google_analytics_id
+
  def index
    @districts = District.all.order(:name)
    @schools = School.all

    @categories = Category.sorted.map { |category| CategoryPresenter.new(category: category) }
  end
+
+  private
+
+  def set_google_analytics_id
+    @google_analytics_id = ENV['GOOGLE_ANALYTICS_ID']
+  end
 end
--- a/app/controllers/sqm_application_controller.rb
+++ b/app/controllers/sqm_application_controller.rb
@ -3,6 +3,7 @@ class SqmApplicationController < ActionController::Base
  layout "sqm/application"
  before_action :set_schools_and_districts
  before_action :authenticate_district
+  before_action :set_google_analytics_id

  private

@ -34,4 +35,8 @@ class SqmApplicationController < ActionController::Base
    end
  end

+  def set_google_analytics_id
+    @google_analytics_id = ENV['GOOGLE_ANALYTICS_ID']
+  end
+
 end
--- a/app/views/layouts/home.html.erb
+++ b/app/views/layouts/home.html.erb
@ -6,6 +6,18 @@
  <%= stylesheet_link_tag 'sqm_application', media: 'all', 'data-turbolinks-track': 'reload' %>
  <%= stylesheet_link_tag 'welcome', media: 'all', 'data-turbolinks-track': 'reload' %>
  <%= javascript_include_tag 'application', 'data-turbolinks-track': 'reload' %>
+  <!-- Global site tag (gtag.js) - Google Analytics -->
+  <script src="https://www.googletagmanager.com/gtag/js?id=<%= @google_analytics_id %>" type="javascript"></script>
+  <script type="javascript">
+    window.dataLayer = window.dataLayer || [];
+
+    function gtag() {
+      dataLayer.push(arguments);
+    }
+
+    gtag('js', new Date());
+    gtag('config', <%= @google_analytics_id.to_json.html_safe %>);
+  </script>
 </head>
 <body>

--- a/app/views/layouts/sqm/application.html.erb
+++ b/app/views/layouts/sqm/application.html.erb
@ -11,7 +11,7 @@
  <%= javascript_include_tag 'application', 'data-turbolinks-track': 'reload' %>

  <!-- Global site tag (gtag.js) - Google Analytics -->
-  <script src="https://www.googletagmanager.com/gtag/js?id=UA-132936999-1" type="javascript"></script>
+  <script src="https://www.googletagmanager.com/gtag/js?id=<%= @google_analytics_id %>" type="javascript"></script>
  <script type="javascript">
    window.dataLayer = window.dataLayer || [];

@ -20,7 +20,7 @@
    }

    gtag('js', new Date());
-    gtag('config', 'UA-132936999-1');
+    gtag('config', <%= @google_analytics_id.to_json.html_safe %>);
  </script>
 </head>