From 47cca3ce1f0805faa0ab4436004ae43fef63e763 Mon Sep 17 00:00:00 2001 From: Nelson Jovel Date: Thu, 21 Dec 2023 13:34:16 -0800 Subject: [PATCH] fix: reduce number of n+1 queries --- app/controllers/overview_controller.rb | 2 +- app/models/category.rb | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/app/controllers/overview_controller.rb b/app/controllers/overview_controller.rb index 28dc4c6c..8e78cd25 100644 --- a/app/controllers/overview_controller.rb +++ b/app/controllers/overview_controller.rb @@ -37,6 +37,6 @@ class OverviewController < SqmApplicationController end def categories - @categories ||= Category.sorted.includes(%i[measures scales admin_data_items subcategories]) + @categories ||= Category.sorted.includes(%i[measures admin_data_items subcategories]) end end diff --git a/app/models/category.rb b/app/models/category.rb index ad546a98..318d3f5f 100644 --- a/app/models/category.rb +++ b/app/models/category.rb @@ -9,5 +9,4 @@ class Category < ActiveRecord::Base has_many :subcategories has_many :measures, through: :subcategories has_many :admin_data_items, through: :measures - has_many :scales, through: :subcategories end