From 4331c017897799306db6c27bccfa72f594bb04c8 Mon Sep 17 00:00:00 2001 From: rebuilt Date: Wed, 9 Jul 2025 22:08:56 -0700 Subject: [PATCH] chore: add includes call to ensure we don't do an n+1 query --- app/services/socio_economic_calculator.rb | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/app/services/socio_economic_calculator.rb b/app/services/socio_economic_calculator.rb index 85d29ae3..1f6ec15e 100644 --- a/app/services/socio_economic_calculator.rb +++ b/app/services/socio_economic_calculator.rb @@ -1,12 +1,12 @@ class SocioEconomicCalculator def self.update_socio_economic_scores parent_list = [].tap do |list| - Parent.all.each do |parent| + Parent.includes(:employments, :benefit, :education).all.each do |parent| parent.socio_economic_status = if has_all_socio_economic_data?(parent:) - socio_economic_score(parent.education, parent.benefit, parent.employments) - else - -1 - end + socio_economic_score(parent.education, parent.benefit, parent.employments) + else + -1 + end list << parent end