-
Distance from benchmark
+
Distance from benchmark
This graph shows how much a score is above or below the benchmark of any given scale.
diff --git a/config/routes.rb b/config/routes.rb
index 6f875801..939b60d2 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -5,6 +5,7 @@ Rails.application.routes.draw do
resources :districts do
resources :schools, only: [:index, :show] do
resources :dashboard, only: [:index]
+ resources :browse, only: [:show]
end
end
diff --git a/spec/factories.rb b/spec/factories.rb
new file mode 100644
index 00000000..d99f7df7
--- /dev/null
+++ b/spec/factories.rb
@@ -0,0 +1,50 @@
+FactoryBot.define do
+ factory :sqm_category do
+ name { "A category" }
+ end
+
+ factory :subcategory do
+ name { "A subcategory" }
+ sqm_category
+
+ factory :subcategory_with_measures do
+ transient do
+ measures_count { 2 }
+ end
+ after(:create) do |subcategory, evaluator|
+ create_list(:measure, evaluator.measures_count, subcategory: subcategory)
+ end
+ end
+ end
+
+ factory :measure do
+ measure_id { rand.to_s }
+ name { 'A Measure' }
+ watch_low_benchmark { 2.0 }
+ growth_low_benchmark { 3.0 }
+ approval_low_benchmark { 4.0 }
+ ideal_low_benchmark { 4.5 }
+ subcategory
+ end
+
+ factory :survey_item do
+ survey_item_id { rand.to_s }
+ measure
+ end
+
+ factory :academic_year do
+ range { '2050-51' }
+ end
+
+ factory :school do
+ name { "#{rand} School" }
+ end
+
+ factory :survey_item_response do
+ likert_score { 3 }
+ response_id { rand.to_s }
+ academic_year
+ school
+ survey_item
+ end
+end
diff --git a/spec/features/school_dashboard_feature_spec.rb b/spec/features/school_dashboard_feature_spec.rb
index 2c0c9f3b..937a59c1 100644
--- a/spec/features/school_dashboard_feature_spec.rb
+++ b/spec/features/school_dashboard_feature_spec.rb
@@ -5,16 +5,21 @@ feature 'School dashboard', type: feature do
let(:school) { School.find_by_slug 'winchester-high-school' }
let(:school_in_same_district) { School.find_by_slug 'muraco-elementary-school' }
+ let(:category) { SqmCategory.find_by_name('Teachers & Leadership') }
+ let(:subcategory) { Subcategory.find_by_name('Teachers & The Teaching Environment') }
+ let(:measures_for_subcategory) { Measure.where(subcategory: subcategory) }
+ let(:survey_items_for_subcategory) { SurveyItem.where(measure: measures_for_subcategory) }
+
let(:measure_1A_i) { Measure.find_by_measure_id('1A-i') }
let(:measure_2A_i) { Measure.find_by_measure_id('2A-i') }
let(:measure_4C_i) { Measure.find_by_measure_id('4C-i') }
let(:survey_item_1_for_measure_1A_i) { SurveyItem.create measure: measure_1A_i, survey_item_id: rand.to_s }
let(:survey_item_2_for_measure_1A_i) { SurveyItem.create measure: measure_1A_i, survey_item_id: rand.to_s }
- let(:survey_item_1_for_measure_2A_i) { SurveyItem.create measure: measure_2A_i, survey_item_id: rand.to_s }
- let(:survey_item_2_for_measure_2A_i) { SurveyItem.create measure: measure_2A_i, survey_item_id: rand.to_s }
- let(:survey_item_1_for_measure_4C_i) { SurveyItem.create measure: measure_4C_i, survey_item_id: rand.to_s }
- let(:survey_item_2_for_measure_4C_i) { SurveyItem.create measure: measure_4C_i, survey_item_id: rand.to_s }
+
+ let(:survey_items_for_measure_1A_i) { SurveyItem.where(measure: measure_1A_i) }
+ let(:survey_items_for_measure_2A_i) { SurveyItem.where(measure: measure_2A_i) }
+ let(:survey_items_for_measure_4C_i) { SurveyItem.where(measure: measure_4C_i) }
let(:measure_row_bars) { page.all('rect.measure-row-bar') }
@@ -24,24 +29,27 @@ feature 'School dashboard', type: feature do
let(:password) { 'winchester!' }
before :each do
- SurveyItemResponse.create response_id: rand.to_s, academic_year: ay_2020_21, school: school,
- survey_item: survey_item_1_for_measure_1A_i, likert_score: 4
- SurveyItemResponse.create response_id: rand.to_s, academic_year: ay_2020_21, school: school,
- survey_item: survey_item_2_for_measure_1A_i, likert_score: 5
-
- SurveyItemResponse.create response_id: rand.to_s, academic_year: ay_2020_21, school: school,
- survey_item: survey_item_1_for_measure_2A_i, likert_score: 5
- SurveyItemResponse.create response_id: rand.to_s, academic_year: ay_2020_21, school: school,
- survey_item: survey_item_2_for_measure_2A_i, likert_score: 5
-
- SurveyItemResponse.create response_id: rand.to_s, academic_year: ay_2020_21, school: school,
- survey_item: survey_item_1_for_measure_4C_i, likert_score: 1
+ survey_items_for_measure_1A_i.each do |survey_item|
+ SurveyItemResponse.create response_id: rand.to_s, academic_year: ay_2020_21, school: school, survey_item: survey_item, likert_score: 4
+ end
+
+ survey_items_for_measure_2A_i.each do |survey_item|
+ SurveyItemResponse.create response_id: rand.to_s, academic_year: ay_2020_21, school: school, survey_item: survey_item, likert_score: 5
+ end
+
+ survey_items_for_measure_4C_i.each do |survey_item|
+ SurveyItemResponse.create response_id: rand.to_s, academic_year: ay_2020_21, school: school, survey_item: survey_item, likert_score: 1
+ end
+
+ survey_items_for_subcategory.each do |survey_item|
+ SurveyItemResponse.create response_id: rand.to_s, academic_year: ay_2020_21, school: school, survey_item: survey_item, likert_score: 4
+ end
end
scenario 'User authentication fails' do
page.driver.browser.basic_authorize('wrong username', 'wrong password')
- visit "/districts/winchester/schools/#{school.slug}/dashboard?year=2020-21"
+ visit "/districts/#{district.slug}/schools/#{school.slug}/dashboard?year=2020-21"
expect(page).not_to have_text(school.name)
end
@@ -59,7 +67,7 @@ feature 'School dashboard', type: feature do
expect(page).to have_text('Professional Qualifications')
professional_qualifications_row = measure_row_bars.find { |item| item['data-for-measure-id'] == '1A-i' }
- expect(professional_qualifications_row['width']).to eq '20.66%'
+ expect(professional_qualifications_row['width']).to eq '10.33%'
expect(professional_qualifications_row['x']).to eq '50%'
expect(page).to have_text('Student Physical Safety')
@@ -78,6 +86,11 @@ feature 'School dashboard', type: feature do
problem_solving_emphasis_row_index = measure_row_bars.find_index { |item| item['data-for-measure-id'] == '4C-i' }
expect(student_physical_safety_row_index).to be < professional_qualifications_row_index
expect(professional_qualifications_row_index).to be < problem_solving_emphasis_row_index
+
+ click_on 'Browse'
+
+ expect(page).to have_text('Teachers & Leadership')
+ expect(page).to have_text('Approval')
end
# visit photos_path
@@ -97,7 +110,7 @@ feature 'School dashboard', type: feature do
expect(page.all('.school-options[selected]')[0].text).to eq 'Winchester High School'
school_options = page.all('.school-options')
- school_options.each_with_index do |school , index|
+ school_options.each_with_index do |school , index|
break if index == school_options.length-1
expect(school.text).to be < school_options[index+1].text
end
@@ -113,7 +126,7 @@ feature 'School dashboard', type: feature do
expect(page.all('.district-options[selected]')[0].text).to eq 'Winchester'
district_options = page.all('.district-options')
- district_options.each_with_index do |district , index|
+ district_options.each_with_index do |district , index|
break if index == district_options.length-1
expect(district.text).to be < district_options[index+1].text
end
diff --git a/spec/models/measure_spec.rb b/spec/models/measure_spec.rb
deleted file mode 100644
index bee568de..00000000
--- a/spec/models/measure_spec.rb
+++ /dev/null
@@ -1,45 +0,0 @@
-require 'rails_helper'
-
-describe Measure, type: :model do
- it('has all the measures') do
- expect(Measure.count).to eq 30
- end
-
- it 'returns the measure for the given measure id' do
- measure = Measure.find_by_measure_id('1A-i')
-
- expect(measure.name).to eq 'Professional Qualifications'
- expect(measure.warning_zone).to eq Measure::Zone.new(1.0, 2.49, :warning)
- expect(measure.watch_zone).to eq Measure::Zone.new(2.49, 3.0, :watch)
- expect(measure.growth_zone).to eq Measure::Zone.new(3.0, 3.5, :growth)
- expect(measure.approval_zone).to eq Measure::Zone.new(3.5, 4.71, :approval)
- expect(measure.ideal_zone).to eq Measure::Zone.new(4.71, 5.0, :ideal)
- end
-
- describe '#zone_for_score' do
- let(:measure) {
- Measure.new watch_low_benchmark: 1.5, growth_low_benchmark: 2.5, approval_low_benchmark: 3.5, ideal_low_benchmark: 4.5
- }
-
- context 'when the score is 1.0' do
- it 'returns the warning zone' do
- expect(measure.zone_for_score(1.0)).to eq measure.warning_zone
- end
- end
-
- context 'when the score is 5.0' do
- it 'returns the ideal zone' do
- expect(measure.zone_for_score(5.0)).to eq measure.ideal_zone
- end
- end
-
- context 'when the score is right on the benchmark' do
- it 'returns the higher zone' do
- expect(measure.zone_for_score(1.5)).to eq measure.watch_zone
- expect(measure.zone_for_score(2.5)).to eq measure.growth_zone
- expect(measure.zone_for_score(3.5)).to eq measure.approval_zone
- expect(measure.zone_for_score(4.5)).to eq measure.ideal_zone
- end
- end
- end
-end
diff --git a/spec/presenters/category_presenter_spec.rb b/spec/presenters/category_presenter_spec.rb
new file mode 100644
index 00000000..fa80b367
--- /dev/null
+++ b/spec/presenters/category_presenter_spec.rb
@@ -0,0 +1,19 @@
+require 'rails_helper'
+
+describe CategoryPresenter do
+ let(:category_presenter) do
+ subcategory1 = Subcategory.new(name: 'A subcategory')
+ subcategory2 = Subcategory.new(name: 'Another subcategory')
+
+ category = SqmCategory.new(name: 'Some Category', subcategories: [subcategory1, subcategory2])
+ return CategoryPresenter.new(category: category, academic_year: AcademicYear.new, school: School.new)
+ end
+
+ it 'returns the name of the category' do
+ expect(category_presenter.name).to eq 'Some Category'
+ end
+
+ it 'maps subcategories to subcategory presenters' do
+ expect(category_presenter.subcategories.map(&:name)).to eq ['A subcategory', 'Another subcategory']
+ end
+end
diff --git a/spec/presenters/gauge_presenter_spec.rb b/spec/presenters/gauge_presenter_spec.rb
new file mode 100644
index 00000000..6ebc230e
--- /dev/null
+++ b/spec/presenters/gauge_presenter_spec.rb
@@ -0,0 +1,120 @@
+require 'rails_helper'
+
+describe GaugePresenter do
+ # let(:academic_year) { create(:academic_year, range: '1989-90') }
+ # let(:school) { create(:school, name: 'Best School') }
+ # let(:subcategory_presenter) do
+ # subcategory = create(:subcategory, name: 'A great subcategory')
+
+ # measure1 = create(:measure, watch_low_benchmark: 4, growth_low_benchmark: 4.25, approval_low_benchmark: 4.5, ideal_low_benchmark: 4.75, subcategory: subcategory)
+ # survey_item1 = create(:survey_item, measure: measure1)
+ # create(:survey_item_response, survey_item: survey_item1, academic_year: academic_year, school: school, likert_score: 1)
+ # create(:survey_item_response, survey_item: survey_item1, academic_year: academic_year, school: school, likert_score: 5)
+
+ # measure2 = create(:measure, watch_low_benchmark: 1.25, growth_low_benchmark: 1.5, approval_low_benchmark: 1.75, ideal_low_benchmark: 2.0, subcategory: subcategory)
+ # survey_item2 = create(:survey_item, measure: measure2)
+ # create(:survey_item_response, survey_item: survey_item2, academic_year: academic_year, school: school, likert_score: 1)
+ # create(:survey_item_response, survey_item: survey_item2, academic_year: academic_year, school: school, likert_score: 5)
+
+ # create_survey_item_responses_for_different_years_and_schools(survey_item1)
+
+ # return SubcategoryPresenter.new(subcategory: subcategory, academic_year: academic_year, school: school)
+ # end
+ let(:scale) do
+ Scale.new(
+ watch_low_benchmark: 1.5,
+ growth_low_benchmark: 2.5,
+ approval_low_benchmark: 3.5,
+ ideal_low_benchmark: 4.5,
+ )
+ end
+ let(:score) { 3 }
+
+
+ let(:gauge_presenter) { GaugePresenter.new(scale: scale, score: score) }
+
+ it 'returns the key benchmark percentage for the gauge' do
+ expect(gauge_presenter.key_benchmark_percentage).to eq 0.625
+ end
+
+ context 'when the given score is in the Warning zone for the given scale' do
+ let(:score) { 1 }
+
+ it 'returns the title of the zone' do
+ expect(gauge_presenter.title).to eq 'Warning'
+ end
+
+ it 'returns the color class for the gauge' do
+ expect(gauge_presenter.color_class).to eq 'fill-warning'
+ end
+
+ it 'returns the score percentage for the gauge' do
+ expect(gauge_presenter.score_percentage).to eq 0.0
+ end
+ end
+
+ context 'when the given score is in the Watch zone for the given scale' do
+ let(:score) { 2 }
+
+ it 'returns the title of the zone' do
+ expect(gauge_presenter.title).to eq 'Watch'
+ end
+
+ it 'returns the color class for the gauge' do
+ expect(gauge_presenter.color_class).to eq 'fill-watch'
+ end
+
+ it 'returns the score percentage for the gauge' do
+ expect(gauge_presenter.score_percentage).to eq 0.25
+ end
+ end
+
+ context 'when the given score is in the Growth zone for the given scale' do
+ let(:score) { 3 }
+
+ it 'returns the title of the zone' do
+ expect(gauge_presenter.title).to eq 'Growth'
+ end
+
+ it 'returns the color class for the gauge' do
+ expect(gauge_presenter.color_class).to eq 'fill-growth'
+ end
+
+ it 'returns the score percentage for the gauge' do
+ expect(gauge_presenter.score_percentage).to eq 0.5
+ end
+ end
+
+ context 'when the given score is in the Approval zone for the given scale' do
+ let(:score) { 4 }
+
+ it 'returns the title of the zone' do
+ expect(gauge_presenter.title).to eq 'Approval'
+ end
+
+ it 'returns the color class for the gauge' do
+ expect(gauge_presenter.color_class).to eq 'fill-approval'
+ end
+
+ it 'returns the score percentage for the gauge' do
+ expect(gauge_presenter.score_percentage).to eq 0.75
+ end
+ end
+
+ context 'when the given score is in the Ideal zone for the given scale' do
+ let(:score) { 5 }
+
+ it 'returns the title of the zone' do
+ expect(gauge_presenter.title).to eq 'Ideal'
+ end
+
+ it 'returns the color class for the gauge' do
+ expect(gauge_presenter.color_class).to eq 'fill-ideal'
+ end
+
+ it 'returns the score percentage for the gauge' do
+ expect(gauge_presenter.score_percentage).to eq 1.0
+ end
+ end
+
+end
diff --git a/spec/presenters/scale_spec.rb b/spec/presenters/scale_spec.rb
new file mode 100644
index 00000000..af27b9dd
--- /dev/null
+++ b/spec/presenters/scale_spec.rb
@@ -0,0 +1,30 @@
+require 'rails_helper'
+
+describe Scale do
+ describe '#zone_for_score' do
+ let(:scale) {
+ Scale.new watch_low_benchmark: 1.5, growth_low_benchmark: 2.5, approval_low_benchmark: 3.5, ideal_low_benchmark: 4.5
+ }
+
+ context 'when the score is 1.0' do
+ it 'returns the warning zone' do
+ expect(scale.zone_for_score(1.0)).to eq scale.warning_zone
+ end
+ end
+
+ context 'when the score is 5.0' do
+ it 'returns the ideal zone' do
+ expect(scale.zone_for_score(5.0)).to eq scale.ideal_zone
+ end
+ end
+
+ context 'when the score is right on the benchmark' do
+ it 'returns the higher zone' do
+ expect(scale.zone_for_score(1.5)).to eq scale.watch_zone
+ expect(scale.zone_for_score(2.5)).to eq scale.growth_zone
+ expect(scale.zone_for_score(3.5)).to eq scale.approval_zone
+ expect(scale.zone_for_score(4.5)).to eq scale.ideal_zone
+ end
+ end
+ end
+end
diff --git a/spec/presenters/subcategory_presenter_spec.rb b/spec/presenters/subcategory_presenter_spec.rb
new file mode 100644
index 00000000..8dea2f02
--- /dev/null
+++ b/spec/presenters/subcategory_presenter_spec.rb
@@ -0,0 +1,37 @@
+require 'rails_helper'
+
+describe SubcategoryPresenter do
+ let(:academic_year) { create(:academic_year, range: '1989-90') }
+ let(:school) { create(:school, name: 'Best School') }
+ let(:subcategory_presenter) do
+ subcategory = create(:subcategory, name: 'A great subcategory')
+
+ measure1 = create(:measure, watch_low_benchmark: 4, growth_low_benchmark: 4.25, approval_low_benchmark: 4.5, ideal_low_benchmark: 4.75, subcategory: subcategory)
+ survey_item1 = create(:survey_item, measure: measure1)
+ create(:survey_item_response, survey_item: survey_item1, academic_year: academic_year, school: school, likert_score: 1)
+ create(:survey_item_response, survey_item: survey_item1, academic_year: academic_year, school: school, likert_score: 5)
+
+ measure2 = create(:measure, watch_low_benchmark: 1.25, growth_low_benchmark: 1.5, approval_low_benchmark: 1.75, ideal_low_benchmark: 2.0, subcategory: subcategory)
+ survey_item2 = create(:survey_item, measure: measure2)
+ create(:survey_item_response, survey_item: survey_item2, academic_year: academic_year, school: school, likert_score: 1)
+ create(:survey_item_response, survey_item: survey_item2, academic_year: academic_year, school: school, likert_score: 5)
+
+ create_survey_item_responses_for_different_years_and_schools(survey_item1)
+
+ return SubcategoryPresenter.new(subcategory: subcategory, academic_year: academic_year, school: school)
+ end
+
+ it 'returns the name of the subcategory' do
+ expect(subcategory_presenter.name).to eq 'A great subcategory'
+ end
+
+ it 'returns a gauge presenter responsible for the aggregate survey item response likert scores' do
+ expect(subcategory_presenter.gauge_presenter.title).to eq 'Growth'
+ end
+
+ def create_survey_item_responses_for_different_years_and_schools(survey_item)
+ create(:survey_item_response, survey_item: survey_item, school: school, likert_score: 1)
+ create(:survey_item_response, survey_item: survey_item, academic_year: academic_year, likert_score: 1)
+ end
+
+end
diff --git a/spec/support/factory_bot.rb b/spec/support/factory_bot.rb
new file mode 100644
index 00000000..c7890e49
--- /dev/null
+++ b/spec/support/factory_bot.rb
@@ -0,0 +1,3 @@
+RSpec.configure do |config|
+ config.include FactoryBot::Syntax::Methods
+end
diff --git a/spec/views/browse/show.html.erb_spec.rb b/spec/views/browse/show.html.erb_spec.rb
new file mode 100644
index 00000000..6b92cf6c
--- /dev/null
+++ b/spec/views/browse/show.html.erb_spec.rb
@@ -0,0 +1,39 @@
+require 'rails_helper'
+
+describe 'browse/show.html.erb' do
+ before :each do
+ academic_year = create(:academic_year, range: '1989-90')
+ school = create(:school, name: 'Best School')
+
+ category = create(:sqm_category, name: 'Some Category')
+
+ subcategory1 = create(:subcategory, sqm_category: category, name: 'A subcategory')
+ subcategory2 = create(:subcategory_with_measures, sqm_category: category, name: 'Another subcategory')
+
+ measure1 = create(:measure, subcategory: subcategory1, watch_low_benchmark: 1.5, growth_low_benchmark: 2.5, approval_low_benchmark: 3.5, ideal_low_benchmark: 4.5)
+
+ survey_item1 = create(:survey_item, measure: measure1)
+
+ survey_item_response1 = create(:survey_item_response, survey_item: survey_item1, academic_year: academic_year, school: school, likert_score: 3)
+
+ assign :category, CategoryPresenter.new(category: category, academic_year: academic_year, school: school)
+
+ render
+ end
+
+ it 'renders the category name' do
+ expect(rendered).to match /Some Category/
+ end
+
+ context 'for each subcategory' do
+ it 'renders the subcategory name' do
+ expect(rendered).to match /A subcategory/
+ expect(rendered).to match /Another subcategory/
+ end
+
+ it 'renders the zone title and fill color for the gauge graph' do
+ expect(rendered).to match /Growth/
+ expect(rendered).to match /fill-growth/
+ end
+ end
+end