Optimize SurveyResponseAggregator via a join

[Finishes #179425717]
4 years ago · 18ddfaaaf8
parent f5724407f2
commit 18ddfaaaf8
1 changed files with 2 additions and 2 deletions
--- a/app/services/survey_response_aggregator.rb
+++ b/app/services/survey_response_aggregator.rb
@ -8,8 +8,8 @@ class SurveyResponseAggregator
  def self.score(academic_year:, school:, measure:)
    SurveyItemResponse
      .where(academic_year: academic_year, school: school)
-      .filter { |survey_item_response| survey_item_response.survey_item.measure == measure }
-      .map { |survey_response| survey_response.likert_score }
+      .joins(:survey_item).where('survey_items.measure_id': measure.id)
+      .map { |survey_item_response| survey_item_response.likert_score }
      .average
  end
 end