From 1851ecf7f8caa672aed5a83c288d85832c1f9e51 Mon Sep 17 00:00:00 2001
From: Nelson Jovel <memoryman51@hotmail.com>
Date: Mon, 12 Aug 2024 16:21:38 -0700
Subject: [PATCH] feat: allow selecting a subset of student survey items for
 the survey item report

---
 app/controllers/exports_controller.rb | 42 +++++++++++++++++++--------
 app/presenters/exports_presenter.rb   | 19 ++++++++++++
 app/views/exports/index.html.erb      | 11 +++++--
 3 files changed, 57 insertions(+), 15 deletions(-)
 create mode 100644 app/presenters/exports_presenter.rb

diff --git a/app/controllers/exports_controller.rb b/app/controllers/exports_controller.rb
index 3d50a71a..b31c14a5 100644
--- a/app/controllers/exports_controller.rb
+++ b/app/controllers/exports_controller.rb
@@ -3,18 +3,20 @@ class ExportsController < ApplicationController
   before_action :authenticate_admin
 
   def index
-    @districts = District.all.map { |district| [district.name, district.id] }
-    @selected_district_id ||= params[:district]&.to_i if params[:district].present?
-    @selected_district_id ||= @districts.first
-    @academic_years = AcademicYear.all.order(range: :ASC)
-    @selected_academic_years = params.select { |param| param.start_with?("academic_year") }.values
+    @presenter = ExportsPresenter.new(params:)
+    @districts = @presenter.districts
+    @selected_district_id = @presenter.selected_district_id
+    @academic_years = @presenter.academic_years
+    @selected_academic_years = @presenter.selected_academic_years
 
-    @schools = School.all.order(name: :ASC)
-    @selected_school ||= School.find_by_name(params[:school])
-    @selected_school ||= @schools.first
+    @schools = @presenter.schools
+    @selected_school = @presenter.selected_school
+
+    @schools_grouped_by = @presenter.schools_grouped_by
 
     @reports = reports.keys
-    @schools_grouped_by = params["school_group"]
+    @student_survey_types = student_survey_types.keys
+    @student_survey_type = params[:student_survey_type]
   end
 
   def show
@@ -33,7 +35,14 @@ class ExportsController < ApplicationController
           schools = [School.find_by_name(params["school"])]
         end
 
-        reports[params[:report]].call(schools, academic_years)
+        report = params[:report]
+
+        if report == "Survey Item - By Item"
+          use_student_survey_items = student_survey_types[params[:student_survey_type]]
+          reports[report].call(schools, academic_years, use_student_survey_items)
+        else
+          reports[report].call(schools, academic_years)
+        end
       end
     end
   end
@@ -63,9 +72,9 @@ class ExportsController < ApplicationController
                                   send_data data, disposition: "attachment",
                                                   filename: "beyond_learning_loss_#{Date.today}.csv"
                                 },
-      "Survey Item - By Item" => lambda { |schools, academic_years|
+      "Survey Item - By Item" => lambda { |schools, academic_years, use_student_survey_items|
                                    data = Report::SurveyItemByItem.to_csv(schools:, academic_years:,
-                                                                          use_student_survey_items: ::SurveyItem.student_survey_items.pluck(:id))
+                                                                          use_student_survey_items:)
                                    send_data data, disposition: "attachment",
                                                    filename: "survey_item_by_item_#{Date.today}.csv"
                                  },
@@ -81,6 +90,15 @@ class ExportsController < ApplicationController
       } }
   end
 
+  def student_survey_types
+    {
+      "All Student Survey Items" => ::SurveyItem.student_survey_items.pluck(:id),
+      "Standard" => ::SurveyItem.standard_survey_items.pluck(:id),
+      "Short Form" => ::SurveyItem.short_form_survey_items.pluck(:id),
+      "Early Education" => ::SurveyItem.early_education_survey_items.pluck(:id)
+    }
+  end
+
   def authenticate_admin
     authenticate("admin", ENV.fetch("ADMIN_PASS"))
   end
diff --git a/app/presenters/exports_presenter.rb b/app/presenters/exports_presenter.rb
new file mode 100644
index 00000000..5855a84d
--- /dev/null
+++ b/app/presenters/exports_presenter.rb
@@ -0,0 +1,19 @@
+class ExportsPresenter
+  attr_reader :districts, :selected_district_id, :academic_years, :selected_academic_years, :schools, :selected_school,
+              :reports, :schools_grouped_by, :show_student_survey_types
+
+  def initialize(params:)
+    @districts = District.all.map { |district| [district.name, district.id] }
+    @selected_district_id ||= params[:district]&.to_i if params[:district].present?
+    @selected_district_id ||= @districts.first
+    @academic_years = AcademicYear.all.order(range: :ASC)
+    @selected_academic_years = params.select { |param| param.start_with?("academic_year") }.values
+
+    @schools = School.all.order(name: :ASC)
+    @selected_school ||= School.find_by_name(params[:school])
+    @selected_school ||= @schools.first
+
+    @schools_grouped_by = params["school_group"]
+    @show_student_survey_types = params[:report] == "Survey Item - By Item"
+  end
+end
diff --git a/app/views/exports/index.html.erb b/app/views/exports/index.html.erb
index 39e54bf7..b390dd19 100644
--- a/app/views/exports/index.html.erb
+++ b/app/views/exports/index.html.erb
@@ -18,14 +18,19 @@
                   </select>
                 </div>
 
-                <h3 class="sub-header-4 mt-5">Report Type</h3>
+                <h3 class="sub-header-4 mt-5">Grouped By</h3>
                 <div class="mt-3">
                   <input type="radio" id="by_district" name="school_group" value="district" <%= @schools_grouped_by == "district" ? "checked" : ""  %>>
-                  <label for="by_district">By District</label><br>
+                  <label for="by_district">District</label><br>
                   <input type="radio" id="by_school" name="school_group" value="school" <%= @schools_grouped_by == "school" ? "checked" : ""  %>>
-                  <label for="by_school">By School</label><br>
+                  <label for="by_school">School</label><br>
                 </div>
 
+                <% if @presenter.show_student_survey_types %>
+                  <h3 class="sub-header-4 mt-5">Student Survey Type</h3>
+                  <%= f.select(:student_survey_type, @student_survey_types, selected: @student_survey_type )  %>
+                <% end %>
+
                 <% if @schools_grouped_by == "district"  %>
                   <h3 class="sub-header-4 mt-5">District</h3>
                   <%= f.select(:district, @districts, selected: @selected_district_id )  %>