From 0b4d8ac7133be41dd0ae72967f3a7b059499d3ad Mon Sep 17 00:00:00 2001
From: Nelson Jovel <memoryman51@hotmail.com>
Date: Tue, 1 Oct 2024 12:05:48 -0700
Subject: [PATCH] chore: extract overview partials

---
 app/views/overview/_student_parent_toggle.html.erb | 13 +++++--------
 app/views/overview/index.html.erb                  |  4 +---
 2 files changed, 6 insertions(+), 11 deletions(-)

diff --git a/app/views/overview/_student_parent_toggle.html.erb b/app/views/overview/_student_parent_toggle.html.erb
index c1ac2ba2..558ec63c 100644
--- a/app/views/overview/_student_parent_toggle.html.erb
+++ b/app/views/overview/_student_parent_toggle.html.erb
@@ -1,10 +1,7 @@
 <div class="btn-group" role="group" aria-label="Basic radio toggle button group">
-<%= link_to(district_school_overview_index_path(@district, @school, year: @academic_year.range, view: "student")) do %>
-  <input type="radio" class="btn-check" name="student_and_teacher_btn" id="student_and_teacher_btn" autocomplete="off" <%= @page.view == "student" ? "checked" : ""  %> >
-  <label class="btn btn-outline-primary" for="student_and_teacher_btn">Students & Teachers</label>
-<% end %>
-<%= link_to(district_school_overview_index_path(@district, @school, year: @academic_year.range, view: "parent")) do %>
-  <input type="radio" class="btn-check" name="parent_btn" id="parent_btn" autocomplete="off"  <%= @page.view == "parent" ? "checked" : ""  %> >
-  <label class="btn btn-outline-primary" for="parent_btn">Parents</label>
-<% end %>
+  <input type="radio" class="btn-check" name="btnradio" id="btnradio1" autocomplete="off" checked>
+  <label class="btn btn-outline-primary" for="btnradio1">Students & Teachers</label>
+
+  <input type="radio" class="btn-check" name="btnradio" id="btnradio2" autocomplete="off">
+  <label class="btn btn-outline-primary" for="btnradio2">Parents</label>
 </div>
diff --git a/app/views/overview/index.html.erb b/app/views/overview/index.html.erb
index 18ae7b75..5950423c 100644
--- a/app/views/overview/index.html.erb
+++ b/app/views/overview/index.html.erb
@@ -9,7 +9,7 @@
 <% cache do   %>
   <%= render partial: "svg_defs"  %>
 <% end  %>
-<% cache [@school, @academic_year, @page.view] do %>
+<% cache [@school, @academic_year] do %>
   <div class="card">
     <div class="d-flex justify-content-between align-items-center">
       <h2 class="sub-header-2">School Quality Framework Indicators</h2>
@@ -18,12 +18,10 @@
     </div>
     <%= render partial: "quality_framework_indicators", locals: { category_presenters: @category_presenters } %>
 
-<% if @page.show_response_rates  %>
     <div class="overall-response-rate-row">
       <%= render partial: "response_rate", locals: {response_rate_presenter: @student_response_rate_presenter} %>
       <%= render partial: "response_rate", locals: {response_rate_presenter: @teacher_response_rate_presenter} %>
     </div>
-  <% end %>
 
   </div>
   <div class="card">