From 05bff3ee8922eb43f092eebae407048b5db489af Mon Sep 17 00:00:00 2001 From: rebuilt Date: Tue, 28 Mar 2023 03:38:52 -0700 Subject: [PATCH] Memoize schools in SurveyItemValues and academic_years in AcademicYear for performace improvement --- app/services/survey_item_values.rb | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/services/survey_item_values.rb b/app/services/survey_item_values.rb index 560bcc56..3593f10f 100644 --- a/app/services/survey_item_values.rb +++ b/app/services/survey_item_values.rb @@ -57,7 +57,7 @@ class SurveyItemValues end def schools - School.all.map { |school| [school.dese_id, school] }.to_h + @schools ||= School.all.map { |school| [school.dese_id, school] }.to_h end def grade @@ -65,7 +65,7 @@ class SurveyItemValues raw_grade = (row['grade'] || row['Grade'] || row['What grade are you in?']) return nil if raw_grade.blank? - raw_grade = raw_grade.to_i + raw_grade.to_i end end