From 001d3083c81d62e5aac30a127ebb482c0326ba87 Mon Sep 17 00:00:00 2001 From: rebuilt Date: Thu, 20 Apr 2023 20:27:01 -0700 Subject: [PATCH] Calculate response rate on the fly instead of looking it up from the db when calculating response rates. --- app/services/race_score_loader.rb | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/app/services/race_score_loader.rb b/app/services/race_score_loader.rb index f7512fc8..a6a102ad 100644 --- a/app/services/race_score_loader.rb +++ b/app/services/race_score_loader.rb @@ -45,7 +45,10 @@ class RaceScoreLoader def self.race_score(measure:, school:, academic_year:, race:) rate = response_rate(school:, academic_year:, measure:) - return Score.new(average: 0, meets_teacher_threshold: false, meets_student_threshold: false, meets_admin_data_threshold: false) unless rate.meets_student_threshold + unless rate.meets_student_threshold + return Score.new(average: 0, meets_teacher_threshold: false, meets_student_threshold: false, + meets_admin_data_threshold: false) + end survey_items = measure.student_survey_items @@ -59,7 +62,7 @@ class RaceScoreLoader memo[[school, academic_year, survey_items, race]] = SurveyItemResponse.joins('JOIN student_races on survey_item_responses.student_id = student_races.student_id JOIN students on students.id = student_races.student_id').where( school:, academic_year: - ).where('student_races.race_id': race.id).group(:survey_item_id).average(:likert_score) + ).where("student_races.race_id": race.id).group(:survey_item_id).average(:likert_score) end @grouped_responses[[school, academic_year, survey_items, race]] @@ -68,8 +71,7 @@ class RaceScoreLoader def self.response_rate(school:, academic_year:, measure:) subcategory = measure.subcategory @response_rate ||= Hash.new do |memo, (school, academic_year, subcategory)| - memo[[school, academic_year, subcategory]] = - ResponseRate.find_by(subcategory:, school:, academic_year:) + memo[[school, academic_year, subcategory]] = subcategory.response_rate(school:, academic_year:) end @response_rate[[school, academic_year, subcategory]]